Skip to content

[NAE-2477] Builder translations - #354

Open
Retoocs wants to merge 19 commits into
release/6.6.0from
NAE-2477
Open

[NAE-2477] Builder translations#354
Retoocs wants to merge 19 commits into
release/6.6.0from
NAE-2477

Conversation

@Retoocs

@Retoocs Retoocs commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Introduce translations for texts in builder components

Implements NAE-2477

Dependencies

No new dependencies were introduced

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Manually

Test Configuration

Name Tested on
OS Ubuntu 24.04.1 LTS
Runtime Node 23.6.1
Dependency Manager NPM 11.0.0
Framework version Angular 19.2.2
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

@Retoocs
[NAE-2477] Builder translations
e5db72d 
- extract text from builder components to en.json
@Retoocs
[NAE-2477] Builder translations
6362833 
- fix entries in en.json
@Retoocs
[NAE-2477] Builder translations
fa04c99 
- translate builder text to SK and DE
@Retoocs
[NAE-2477] Builder translations
696e9eb 
- use translation in dialog HTML components
- add todos
- import translate module in builder modules
@Retoocs
[NAE-2477] Builder translations
65c39aa 
- use translation in dialog HTML components
- add todos
- import translate module in builder modules
@Retoocs
[NAE-2477] Builder translations
2267570 
- apply translation for modeler.actions-mode components
@Retoocs
[NAE-2477] Builder translations
2dbf8b9 
- apply translation for modeler.data-mode components
@Retoocs
[NAE-2477] Builder translations
4776371 
- apply translation for modeler.history-mode components
@Retoocs
[NAE-2477] Builder translations
ba5f07c 
- apply translation for modeler.i18n-mode components
@Retoocs
[NAE-2477] Builder translations
7d04e1d 
- apply translation for modeler.role-mode components
@Retoocs
[NAE-2477] Builder translations
54d7181 
- apply translation for dialog TS files
@Retoocs
[NAE-2477] Builder translations
50d892d 
- apply translation for form-builder TS files
@Retoocs
[NAE-2477] Builder translations
2f1413c 
- apply translation for tutorial TS files
@Retoocs
[NAE-2477] Builder translations
a38fd80 
- apply more translations in TS files
@Retoocs
[NAE-2477] Builder translations
0fa9727 
- apply more translations in TS files
@Retoocs
[NAE-2477] Builder translations
5b65b84 
- fix some translations
@Retoocs Retoocs self-assigned this Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 127b1550-f2ed-49b6-bb51-8cf743b78932

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Retoocs
[NAE-2477] Builder translations
220ffb8 
- apply more translations
- fix some translations
@Retoocs
[NAE-2477] Builder translations
f302ef1 
- fix tests
@Retoocs
Retoocs marked this pull request as ready for review September 18, 2026 10:26
@sonarqubecloud

sonarqubecloud Bot commented Sep 18, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
22.7% Coverage on New Code (required ≥ 50%)
29.7% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Kovy95
Kovy95 reviewed Sep 21, 2026
View reviewed changes
Comment thread projects/netgrif-components/src/lib/builder/modeler/edit-mode/edit-mode.service.ts Outdated
new ResetPositionAndZoomTool(context),
new GridTool(context),
new SwitchLabelTool(context)
new ClearModelTool(context, _translateService),

@Kovy95 Kovy95 Sep 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you dont add translate service to CanvasToolContext ? it is for passing all dependencies to tools

@Retoocs Retoocs Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I fixed it

@Retoocs
[NAE-2477] Builder translations
32c0f26 
- optimize constructor dependencies
@Retoocs
Retoocs requested a review from Kovy95 September 21, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuplle tuplle Awaiting requested review from tuplle
@SamuelPalaj SamuelPalaj Awaiting requested review from SamuelPalaj
@renczesstefan renczesstefan Awaiting requested review from renczesstefan
@machacjozef machacjozef Awaiting requested review from machacjozef
@mazarijuraj mazarijuraj Awaiting requested review from mazarijuraj
@Kovy95 Kovy95 Awaiting requested review from Kovy95

Requested changes must be addressed to merge this pull request.

Assignees

@Retoocs Retoocs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Retoocs @Kovy95