feat: cert file and TLS skip verify - #62
Merged
Merged
Conversation
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
…certificates and TLS verification Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
…e usage Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
mfiedorowicz
requested review from
MicahParks,
jajeffries,
leoparente and
ltucker
as code owners
August 28, 2025 13:00
MicahParks
approved these changes
Aug 28, 2025
jajeffries
approved these changes
Aug 28, 2025
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for custom TLS certificate files and configurable TLS verification for the Diode client, improving security and flexibility when connecting to secure endpoints. It introduces new environment variables and constructor parameters, updates documentation, and refactors certificate handling logic to allow users to specify custom certificates and control TLS verification behavior.
TLS and Certificate Handling Improvements:
cert_fileparameter inDiodeClientand theDIODE_CERT_FILEenvironment variable; certificates are loaded and used for secure connections. [1] [2] [3]DIODE_SKIP_TLS_VERIFYenvironment variable and logic to control TLS verification based on the target URL scheme and environment variable, allowing users to disable verification for testing or non-production use. [1] [2]Documentation Updates:
README.mdto document new environment variables (DIODE_CERT_FILE,DIODE_SKIP_TLS_VERIFY), constructor parameters, and provided usage examples for custom certificates and TLS verification settings. [1] [2]Configuration Refactoring: