Skip to content

Add a button to toggle line numbers - #3091

Open
swoolcock wants to merge 2 commits into
nesbox:mainfrom
swoolcock:line-number-button
Open

swoolcock wants to merge 2 commits into
nesbox:mainfrom
swoolcock:line-number-button

Conversation

@swoolcock

Copy link
Copy Markdown
Contributor

I think it looks good at the bottom of the gutter.

image image

# Conflicts:
#	config.js
#	src/studio/studio.h
@nesbox

nesbox commented Oct 15, 2026

Copy link
Copy Markdown
Owner

Maybe better to place the button in the status bar before line 1/123?

@swoolcock

swoolcock commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Maybe better to place the button in the status bar before line 1/123?

I initially tried that but it looked kind of janky and out of place. It would need to always remain white otherwise the status bar looks bad. How else would we show the button being on or off?

I'll get opinions from Discord.

@MineRobber9000

Copy link
Copy Markdown
Contributor

I don't think the button needs to signal on/off; the line numbers being in the gutter will make that clear enough. I do kind of agree with nesbox that it'd be better on the status line on the bottom, turning a different color when hovered a la cut/copy/paste/etc. to indicate that it's clickable, but that's just my opinion.

@swoolcock

swoolcock commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor Author

I don't think the button needs to signal on/off; the line numbers being in the gutter will make that clear enough. I do kind of agree with nesbox that it'd be better on the status line on the bottom, turning a different color when hovered a la cut/copy/paste/etc. to indicate that it's clickable, but that's just my opinion.

I'll give that a shot.

@KeplerElectronics

KeplerElectronics commented Oct 16, 2026 •

Copy link
Copy Markdown
Screenshot 2026-10-15 at 8 47 29 PM

I'm in favor of putting it in the gutter.

With Pro enabled and 5-digit line counts, the status bar is already completely full with no extra whitespace remaining.

@swoolcock

Copy link
Copy Markdown
Contributor Author

I'm in favor of putting it in the gutter.

With Pro enabled and 5-digit line counts, the status bar is already completely full with no extra whitespace remaining.

This was kind of my concern too, especially as I have other plans for the status bar!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants