gather a summary's commits once instead of seven times - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summaryasked seven questions about one set of commits andwith()reselected that set for each of them. On a 200k commit index the seven queries summed to 0.82s, which was the whole command.Gather the set once into a temp table and read from it. The counterpart role keeps its own scan: it is a different set and that is one scan for one number.
id, date and time. The object id and subject belong to two commits out of however many the set holds, so those two are looked up when they are asked for.repositoriesis the number of groupstop_repositoriesalready computes, so one grouping now answers both. That removed a query rather than adding one.Closes #8.