rank identity candidates before counting their repositories - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
identity_candidates()computed the distinct repository count for every identity in the index, then threw all but twenty away. That count is the expensive one:EXPLAIN QUERY PLANgives itMULTI-INDEX ORand a temp B-tree for theDISTINCTwhile the two counts it is ranked by are covering-index lookups.Rank on the cheap counts first, ask for the repository count only for the twenty rows that survive. Same columns, same ordering, same values.
The old shape got cheaper as identities grew, because the per identity count then walked fewer commits each. Its worst case is a small team with a long history which is gitlife's subject.
summaryend to end, on an index built from a 20k commit repository with 50 authors: 0.03–0.04 s to 0.01–0.02 s.Closes #9