Repository navigation
Conversation
…extraction) Adds an outbound integration that extracts an uploaded video's audio track as mono 16 kHz WAV (audio/wav) with ffmpeg, ready for Integration.Audio.Transcribe. The process boundary is an injectable Runner record, so the tests use a fake runner and never need ffmpeg. Registers the nhintegrations-test hspec suite in test-surfaces.json.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
Hey, thanks a lot for this PR! A few things to fix:
Thanks! |
Member
|
I found one more contract mismatch to fix:
Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps can extract an uploaded video's audio as mono 16 kHz WAV, then pass that audio to the existing transcription integration.
Integration.Video.ExtractAudioruns local ffmpeg; chaining extraction, upload and transcription remains the application's job.Review follow-up
eventProcessingTimeoutMsthroughApplication.withDispatcherConfig. The extraction default remains unchanged.onErrorfrom the worker being cancelled by a shorter dispatcher deadline.Integration.Video.ExtractAudio.Internal ()and carries audio as Base64 text, not unserializableBytesor lossy UTF-8 text.Bytes.fromBase64beside Core's existing encoder. It rejects malformed input and requires no new dependency or raw Haskell imports in application code. Tests cover known answers, every byte value, padding, empty and invalid input.Verification
Local pinned-toolchain results:
Integration.Video: 15 examples, 0 failures; repeated runs pass.Bytesselection: 14 examples, 0 failures. Full Core suite: 1100 examples, 0 failures, 3 pending.The full integrations suite reports 621 examples and 2 failures in existing Oura SyncAll network tests; the same two fail on the original PR head. This is not a full-suite-green claim. No real ffmpeg, PostgreSQL/Hurl acceptance run or PR-ready security-review receipt is claimed here. Still a draft pending maintainer review.
Migration: existing apps need no change. Apps using this new integration need ffmpeg and a dispatcher deadline longer than extraction plus file-access overhead. Spec 018.