Link advapi32 on Windows for graph_mate - #149
Merged
Merged
Conversation
nanorand (via graph_builder) calls RtlGenRandom (SystemFunction036) without declaring the advapi32 link dependency, and Rust toolchains no longer link advapi32 implicitly. This broke the Windows wheel builds at the final cdylib link step. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
s1ck
enabled auto-merge
June 10, 2026 13:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The graph_mate 0.2.0 release run failed linking the Windows wheels:
unresolved external symbol SystemFunction036(RtlGenRandom), referenced by nanorand via graph_builder. nanorand 0.7 doesn't declare its advapi32 dependency and Rust stopped linking advapi32 implicitly, which is why this only appears now — the Windows packaging jobs run exclusively on release tags and the last graph_mate release predates the toolchain change.A
build.rsin graph_mate links advapi32 on Windows, fixing both the CI wheel builds and sdist builds on Windows user machines.Failed run: https://github.com/neo4j-labs/graph/actions/runs/27277863582
🤖 Generated with Claude Code