DOCOPS-184 Use rem for media queries to set break points - #380
Merged
Conversation
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use break points to show or hide navigation, for example, and depending on user settings it is possible for navigation to be displayed instead of hidden at specific page widths.
We use media queries in the css to set the break points.
User settings such as browser zoom or OS display settings can affect the width at which break points actually occur, resulting in the page not be displayed correctly. For example, navigation being displayed when we want it to be hidden, by using a media query.
The fix is to replace
pxwithremvalues in media queries so break points always trigger at the correct page width, regardless of user settings.