Repository navigation
feat: make max file size configurable via asset upload settings - #38
Open
andrey-canon wants to merge 1 commit into
Open
andrey-canon wants to merge 1 commit into
andrey-canon wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the maximum file size for asset uploads configurable through the application configuration.
Previously, the limit was hardcoded to a fixed value. Now, the system attempts to fetch
MAX_ASSET_UPLOAD_FILE_SIZE_IN_MBfrom the configuration. If this value is not defined or the API call fails, it gracefully falls back to the constantUPLOAD_FILE_MAX_SIZE.Issue # 1725
Migration pr of #28
Changes
maxFileSizeconstant with a dynamic configuration lookup.Screenshots
Before
20 * 1048576(Fixed 20MB).After
getConfig().MAX_ASSET_UPLOAD_FILE_SIZE_IN_MBwith fallback toUPLOAD_FILE_MAX_SIZE.