feat: tenant path middleware - #321
Open
johanseto wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrotion
Fix tenant restriction middleware settings lookup and add coverage for path-based access control
Summary
This change adds tenant restriction middleware and adds unit tests to cover expected access behavior.
What changed
TenantRestrictionPathMiddlewareto readTENANT_RESTRICTION_PATHSfrom Django settings at request time instead of caching them during initialization.TEsts
Configure settings with
Check the page without session force you to be logged,
Before
After
Screencast.from.14-08-26.17.15.53.webm
#Testing
Validated with:
Result:
jira story: https://edunext.atlassian.net/browse/FUTUREX-1842?atlOrigin=eyJpIjoiNTk0M2UyMDUwNzFkNGQ4Y2JjNGU5ZDQ3YjFjZDFhZTMiLCJwIjoiaiJ9