Conversation
as edx-platform has django ATOMIC_REQUEST set to true this is not necessary
andrey-canon
left a comment
andrey-canon
left a comment
Collaborator
There was a problem hiding this comment.
I agree that it is not necessary, but you didn't explain how this change will improve the DB behavior.
Collaborator
Author
I want to test hehehe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As edx-platform has django
ATOMIC_REQUESTSset to true, this is not necessaryThis is a proposal to test to improve the behaviour of the auth user locked table.
https://www.stanza.dev/courses/django-orm-mastery/transactions/django-orm-mastery-savepoints
https://medium.com/@moosaabdullahi45/safe-guide-to-realiable-database-operations-using-django-atomic-transactions-10c89da5f5aa
https://forum.djangoproject.com/t/ability-to-skip-nested-transactions/4826/2