Repository navigation
fix: require Django staff to call set_course_mode_price endpoint - #99
Merged
johanseto merged 1 commit intoOct 1, 2026
Merged
Conversation
andrey-canon
force-pushed
the
open-release/teak.nelp
branch
from
October 1, 2026 20:57
fa870d0 to
e57b2e4
Compare
The set_course_mode_price view had no authorization check beyond @login_required, meaning any authenticated user could POST to it and rewrite the honor-mode price for any course — a privilege escalation vulnerability. Ideally this endpoint would be removed: it has no known callers in the UI (no templates or JS reference it), no tests, and targets the legacy 'honor' mode. However, it is publicly routed and external consumers may depend on it, so removal requires going through the DEPR process before we can act. In the meantime, this commit closes the security hole regardless of how active the endpoint is. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
johanseto
force-pushed
the
jlc/course-mode-security-backport
branch
from
October 1, 2026 21:04
3a80e8f to
134d9c6
Compare
andrey-canon
approved these changes
Oct 1, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports the authorization fix from openedx/openedx-platform@fd93ef5 to address GHSA-rqq6-w4pv-7pjv.
The set_course_mode_price endpoint now requires Django staff permissions, preventing authenticated non-staff users from changing honor-mode prices for arbitrary courses. This affects Operators and any external consumers of this legacy endpoint.
Supporting information
• Upstream fix: openedx@fd93ef5
• Security advisory: GHSA-rqq6-w4pv-7pjv
Testing instructions
Deadline
None.
Other information
This is a targeted security backport with no configuration or database migration changes.Description
Backports the authorization fix from openedx/openedx-platform@fd93ef5 to address GHSA-rqq6-w4pv-7pjv.
The set_course_mode_price endpoint now requires Django staff permissions, preventing authenticated non-staff users from changing honor-mode prices for arbitrary courses. This affects Operators and any external consumers of this legacy endpoint.
Supporting information
• Upstream fix: openedx@fd93ef5
• Security advisory: GHSA-rqq6-w4pv-7pjv
Testing instructions
Deadline
None.
Other information
This is a targeted security backport with no configuration or database migration changes.