Repository navigation
Fail the build if coverage falls - #124
Merged
Merged
Conversation
Coverage was measured on every run and compared against nothing, so it could drop without anything noticing. The floor is set just below where it stands rather than as a target to chase.
Parts of the suite download a genome, so a runner without network runs fewer tests and reaches about 60% where a local run reaches 65%. A floor at 63 failed on macOS for that reason rather than for any real regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage was measured on every run and compared against nothing.
Floor set to 58% — below the worst case, not the best: parts of the suite download a genome, so a runner without network reaches ~60% where a local run reaches 65%. A floor at 63 failed on macOS for that reason alone.
That platform variance is the real problem; filed separately.