Repository navigation
Quest drops shared with the party: shown to and taken by whoever still needs them - #714
Merged
Merged
Conversation
… on the map sees and may take one only while they still need it
…te, unit test for party rolls and needs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEDGER row 197 (quest-drop visibility for party), following Cosmic's
MapleMap.spawnDrop/needQuestItem.ServerMessage::QuestDrop. The client actor shows it only ifnet::loot::wantsholds: the quest is started and the player holds fewer than the completion check asks for. This applies on spawn, on entering the field, and toReturnDrop. Removals go to everyone, and the client ignores oids it never saw.QuestNeeds::of(player).DropSet::takeable_byrefuses a quest drop to anyone who doesn't need it, the owner included, then applies the usual ownership rules.net::lootandruntime::field_drops.a_party_members_quest_drop_shows_only_to_the_one_who_needs_it. The hunter without Todd's quest kills a sentinel; only the helper on the quest sees the shellpiece and can take it.