Skip to content

Family Rep: earning from kills and levels; level-up and job notices - #713

Merged
neeerp merged 1 commit into
masterfrom
v83/family-rep
Oct 22, 2026
Merged

neeerp merged 1 commit into
masterfrom
v83/family-rep

Conversation

@neeerp

@neeerp neeerp commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Family slice 3 (LEDGER row 204, report b049).

Server

  • Juniors earn Rep for their senior and the senior's senior: 4 for each kill they get EXP from, 20 for a boss, and 200 per level. These are Cosmic's numbers, since v83's own rule isn't known. The gain is halved once the junior's level is above the direct senior's.
  • db::family::earn updates current, total and today's Rep, plus the Rep the junior has recorded to the senior, in one transaction. It locks rows in ascending id order, as separate/add_junior do.
  • New rep_day column: the daily counters read as 0 on any later day.
  • Each earner gets FAMILY_REP_GAIN (0x65: gain and the junior's name), then INFO again.
  • NOTIFY_LEVELUP goes to the online senior once per level. It is type 0 when the junior has passed the senior's level, else type 1. NOTIFY_JOB_CHANGE type 1 ("> name") goes to the senior and the juniors.

Client

  • When NOTIFY_LEVELUP is type 0 and the level is above the player's own, the client adds "- The Reps you have received from %s will be reduced in half." (pool 0x1246, 0xa1396f).

Tests

  • New harness test: a junior's kill that also levels them up gives both seniors [REP_GAIN 200, REP_GAIN 4] and INFO 204/204/204. Only the direct senior gets the level notice.
  • Unit tests for rep_gain and the type-0 notice.
  • Results: harness families 3/3, guilds 7/7; net/game family unit tests pass; HC dbg ctest 152/152.
  • A Sonnet review found nothing serious.

…ill, 20 per boss, 200 per level (b049, halved once past the senior), today counters by rep_day; NOTIFY_LEVELUP/NOTIFY_JOB_CHANGE to relatives, and HC's halving line
@neeerp
neeerp merged commit 06e7f1e into master Oct 22, 2026
1 check passed
@neeerp
neeerp deleted the v83/family-rep branch October 22, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant