Repository navigation
Family Rep: earning from kills and levels; level-up and job notices - #713
Merged
Merged
Conversation
…ill, 20 per boss, 200 per level (b049, halved once past the senior), today counters by rep_day; NOTIFY_LEVELUP/NOTIFY_JOB_CHANGE to relatives, and HC's halving line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Family slice 3 (LEDGER row 204, report b049).
Server
db::family::earnupdates current, total and today's Rep, plus the Rep the junior has recorded to the senior, in one transaction. It locks rows in ascending id order, asseparate/add_juniordo.rep_daycolumn: the daily counters read as 0 on any later day.FAMILY_REP_GAIN(0x65: gain and the junior's name), then INFO again.NOTIFY_LEVELUPgoes to the online senior once per level. It is type 0 when the junior has passed the senior's level, else type 1.NOTIFY_JOB_CHANGEtype 1 ("> name") goes to the senior and the juniors.Client
NOTIFY_LEVELUPis type 0 and the level is above the player's own, the client adds "- The Reps you have received from %s will be reduced in half." (pool 0x1246, 0xa1396f).Tests
[REP_GAIN 200, REP_GAIN 4]and INFO 204/204/204. Only the direct senior gets the level notice.rep_gainand the type-0 notice.families3/3,guilds7/7;net/gamefamily unit tests pass; HC dbg ctest 152/152.