Repository navigation
c29: Disorder and Hypnotize hits draw no aggro and end the mob's chase - #706
Merged
Merged
Conversation
…s chase (c021: 0x7a82a2 passes 0 to FUN_007f73d8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v83, the local player's hits with Disorder (4001002, 14001002) and Hypnotize (5221009) don't make the mob chase them. Instead the mob gives up any chase it had: the attack drivers pass aggro flag 0 to FUN_007f73d8 (0x7a82a2), and every other skill passes 1. This was found in lane C's c021 report.
Server
net::skills::provokes(skill).FieldActor::handle_attackno longer hands the mob over with aggro (SPAWN_MONSTER_CONTROL 2) for these three skills. If it did, the chase would start again and undo what the client just did.HeavenClient
damage_layout::provokes.AttackUser::calmsflag, set only for the local player's hits.MapMobs::apply_damagecalls the newMob::calm(). For a mob this client controls, it drops the chase target and rebuilds the shoe, as 5cc3d9 does with 7f73d8 and then 5c55cd.Tests
hypnotizeharness test: a Hypnotize hit draws no aggro, and a plain hit on the same snail then does.hypnotizeandmob_combatpass.netskills unit test.No GUI recording. The client change only clears a chase flag on hit. The server half is covered by the harness test.