Skip to content

HeavenClient: script progress lines (0x7A) and QUEST_CLEAR cards (0x31) - #705

Merged
neeerp merged 3 commits into
masterfrom
v83/script-progress-client
Oct 22, 2026
Merged

neeerp merged 3 commits into
masterfrom
v83/script-progress-client

Conversation

@neeerp

@neeerp neeerp commented Oct 22, 2026

Copy link
Copy Markdown
Owner

HeavenClient now handles the two packets the exploration medals (#701) send. Row 198 follow-up; RE in v83ref reports/a050.

  • SCRIPT_PROGRESS_MESSAGE (0x7A) — UIScriptMessage over FloatingLines: v83's five floating lines (FUN_00a13f20, FUN_006ce251). Gold #FFC600 Arial bold 15 with a black edge, centred, at y = 150, 130, … 70. Each is shown for 3 s, then fades over 3 more. A line takes the first slot that was never used or was shown more than 3 s ago; with all five busy, it is dropped. Empty strings are ignored.
  • QUEST_CLEAR (0x31) — UIQuestComplete::add_notice(id): the existing "Quest Complete!" card (FUN_00a26d44, type 7).
    • Notices now stay while QuestLog::is_started(id), rather than only while the quest is in the catalog. The explorer quests aren't in supported_quests.txt, so their card vanished on the next frame.
    • Names come from QuestInfo.img/<id>/name.
  • Quest text — #R<quest># is filled in with that quest's record, so Beginner Explorer reads "Status : 20 / 20 Completed" instead of "27010 / 20".

Verification:

  • ctest 151/151 in build-dbg, including the new floating_lines test.
  • GUI check on a private Xvfb display: Lanea (level 30) with 19 Victoria places seeded logs in at Florina Beach. The gold line appears and fades, and the Quest Complete! "Beginner Explorer" card shows. Pressing O on the card opens the quest log, which shows "20 / 20".
  • Sonnet review a054 found no bugs. Its low findings are fixed: plain text, the strict 3 s, the lines stay on top, edges fade faster, and the CMake entry.

Known approximation: v83 fades the outlined line as one layer. Here the edges are drawn separately, at the square of the opacity.

…R (0x31) Quest Complete card; server notices kept for quests outside the catalog; #R<quest># shows a quest record in quest text
…tay on top; edges fade faster; #R ids up to 5 digits; FloatingLines.h listed
@neeerp
neeerp merged commit e325761 into master Oct 22, 2026
1 check passed
@neeerp
neeerp deleted the v83/script-progress-client branch October 22, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant