Repository navigation
HeavenClient: script progress lines (0x7A) and QUEST_CLEAR cards (0x31) - #705
Merged
Merged
Conversation
…R (0x31) Quest Complete card; server notices kept for quests outside the catalog; #R<quest># shows a quest record in quest text
…tay on top; edges fade faster; #R ids up to 5 digits; FloatingLines.h listed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HeavenClient now handles the two packets the exploration medals (#701) send. Row 198 follow-up; RE in v83ref reports/a050.
UIScriptMessageoverFloatingLines: v83's five floating lines (FUN_00a13f20, FUN_006ce251). Gold #FFC600 Arial bold 15 with a black edge, centred, at y = 150, 130, … 70. Each is shown for 3 s, then fades over 3 more. A line takes the first slot that was never used or was shown more than 3 s ago; with all five busy, it is dropped. Empty strings are ignored.UIQuestComplete::add_notice(id): the existing "Quest Complete!" card (FUN_00a26d44, type 7).QuestLog::is_started(id), rather than only while the quest is in the catalog. The explorer quests aren't insupported_quests.txt, so their card vanished on the next frame.QuestInfo.img/<id>/name.#R<quest>#is filled in with that quest's record, so Beginner Explorer reads "Status : 20 / 20 Completed" instead of "27010 / 20".Verification:
ctest151/151 in build-dbg, including the newfloating_linestest.Known approximation: v83 fades the outlined line as one layer. Here the edges are drawn separately, at the square of the opacity.