Repository navigation
c28 HC: Battleship Cannon and Torpedo fire - #704
Merged
Merged
Conversation
…00969a57); without them the keys did nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HeavenClient's
SkillData::flags_ofleft Battleship Cannon (5221007) and Torpedo (5221008) out of itsshotsset. They got no attack flags, so their keys did nothing. The rest of HC already handles both (the ship gate, shot paths, remote shots, damage), and v83 fires them through the shot path (FUN_00969a57, reports/228 and c020 section 2).GUI check on the lane's private display with Lanec (a level 120 Corsair, gun and bullets) in Henesys Hunting Ground I, riding the Battleship:
No unit test:
flags_ofis a static table inside SkillData, which needs the NX files. The release client builds.