Skip to content

c26 Legendary Spirit server - #702

Merged
neeerp merged 1 commit into
masterfrom
v83/legendary-spirit
Oct 22, 2026
Merged

neeerp merged 1 commit into
masterfrom
v83/legendary-spirit

Conversation

@neeerp

@neeerp neeerp commented Oct 22, 2026

Copy link
Copy Markdown
Owner

Legendary Spirit (1003 / 10001003 / 20001003) opens a dialog that scrolls an equip in the Equip tab. That dialog sends USE_UPGRADE_SCROLL with a positive slot and a last byte of 1 (reports/c018). Until now the server refused all of these requests.

  • The request is accepted only from a player who has one of the three skills. It uses the same rules as a worn equip (fits, req, slots left, not cash), except that pet equipment (180xxxx) may pass the cash refusal, as the client's dialog allows.
  • On success, the Equip-tab item is replaced. SHOW_SCROLL_EFFECT goes to the scroller and the map with the Legendary Spirit flag set. No look refresh is sent, because the item is not worn.
  • On refusal (no skill, a worn slot, an empty slot, a misfit), the dialog gets SHOW_SCROLL_EFFECT -1 ("You cannot use a Scroll with this item."). Non-dialog requests behave as before.
  • The HeavenClient dialog is a later slice; its RE (c022) is in progress.

Tests:

  • New net unit tests: legendary_spirit_scrolls_a_sword_in_the_equip_tab and legendary_spirit_takes_only_the_equip_tab.
  • New harness test: scrolls::legendary_spirit_scrolls_a_sword_in_the_equip_tab. It covers a refusal without the skill, a success with it, a refusal for a worn slot, and the upgrade being saved.
  • The harness scroll helpers now filter by character, because two tests now scroll on the same map.

…st byte 1) scrolls an unequipped equip for a player with 1003/10001003/20001003, same rules (pet equips pass the cash refusal), effect with Legendary Spirit set and no look refresh; refusals answer -1 to the dialog
@neeerp
neeerp merged commit 82c57e3 into master Oct 22, 2026
1 check passed
@neeerp
neeerp deleted the v83/legendary-spirit branch October 22, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant