Repository navigation
c26 Legendary Spirit server - #702
Merged
Merged
Conversation
…st byte 1) scrolls an unequipped equip for a player with 1003/10001003/20001003, same rules (pet equips pass the cash refusal), effect with Legendary Spirit set and no look refresh; refusals answer -1 to the dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legendary Spirit (1003 / 10001003 / 20001003) opens a dialog that scrolls an equip in the Equip tab. That dialog sends USE_UPGRADE_SCROLL with a positive slot and a last byte of 1 (reports/c018). Until now the server refused all of these requests.
req, slots left, not cash), except that pet equipment (180xxxx) may pass the cash refusal, as the client's dialog allows.Tests:
legendary_spirit_scrolls_a_sword_in_the_equip_tabandlegendary_spirit_takes_only_the_equip_tab.scrolls::legendary_spirit_scrolls_a_sword_in_the_equip_tab. It covers a refusal without the skill, a success with it, a refusal for a worn slot, and the upgrade being saved.