Fix double-free crash in socket_client_task on disconnect - #75
Open
MichaelEFlip wants to merge 1 commit into
Open
MichaelEFlip wants to merge 1 commit into
MichaelEFlip wants to merge 1 commit into
Conversation
When the socket client successfully connects, connect_message is freed at line 93. On subsequent disconnection, execution falls through to the _error label which calls free(connect_message) again. This corrupts the heap allocator (TLSF), triggering an assertion failure: "!block_is_free(block) && block already marked as free" causing a panic reboot. The crash was confirmed via core dump analysis (task: socket_client_t, heap_tlsf.c:866) and reproduced by stopping the remote TCP endpoint — the device crashed on every disconnect/reconnect cycle. Fix: set connect_message = NULL after the first free, making the second free(NULL) a safe no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the socket client successfully connects, connect_message is freed at line 93. On subsequent disconnection, execution falls through to the _error label which calls free(connect_message) again. This corrupts the heap allocator (TLSF), triggering an assertion failure: "!block_is_free(block) && block already marked as free" causing a panic reboot.
The crash was confirmed via core dump analysis (task: socket_client_t, heap_tlsf.c:866) and reproduced by stopping the remote TCP endpoint — the device crashed on every disconnect/reconnect cycle.
Fix: set connect_message = NULL after the first free, making the second free(NULL) a safe no-op.