core: destroy parser on disconnect in libuv-adapter mode - #1008
Open
arnaudhe wants to merge 1 commit into
Open
Conversation
AdamPayzant
requested changes
Aug 5, 2026
AdamPayzant
left a comment
AdamPayzant
left a comment
Collaborator
There was a problem hiding this comment.
The changes look good to me, but please add a test for these changes. If you need help or want me to do it just let me know
Member
|
@AdamPayzant Not sure how the user can test that in the test suite to be honest. Would have to be using a mock, capture the nc->ps address, send a bad protocol, make sure that nc->ps is changed I guess? |
Collaborator
|
@kozlovic Maybe I didn't look at it deep enough, but I thought |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue where protocol parser is not destroyed at disconnect when running with libuv adapter. Implements deferred destroy via a bool psReset flag on natsConnection.
Related Issues
Fixes #1007