Improve unit test coverage for CF_CFDP_CopyStringFromLV#504
Open
abnsy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
This contribution improves unit test coverage for CF_CFDP_CopyStringFromLV().
Additional test cases were added to verify existing error handling paths, including:
Destination buffer too small
NULL source logical value pointer
NULL destination buffer pointer
Zero-sized destination buffer
NULL source data pointer with non-zero length
No production code changes are included.
Fixes: N/A
Testing performed
Updated unit-test/cf_cfdp_tests.c
Executed unit tests
Verified successful build and test execution
Expected behavior changes
API Change: None
Behavior Change: None
Impact: No operational impact. This change only improves unit test coverage for existing validation logic.
System(s) tested on
Hardware: PC
OS: Windows 11
Versions:
CF current development branch
Git for Windows
VS Code
Additional context
The new test cases exercise existing defensive input validation paths that were previously not explicitly covered by unit tests.
Third party code
None.
Contributor Info - All information REQUIRED for consideration of pull request
Full name: Albern Surya Adi
Organization: Personal