fix: Package to paths.dist_dir()#706
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Nanvix CPython release packaging to place generated release tarballs in the configured distribution directory (nanvix_zutil.paths.dist_dir()), and removes the explicit pre-install build step from the release packaging flow (relying on make install’s dependency on build).
Changes:
- Switch release artifact output from
repo_root / "dist"topaths.dist_dir()in bothpackage()andverify(). - Remove the explicit
build_mod.build(...)invocation frompackage()(packaging now starts at install).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ada-x64
force-pushed
the
fix/release-v0.11.1
branch
from
f95b7ca to
10a35d1
Compare
Comment on lines
210
to
212
| artifact = _artifact_base(platform, process_mode, memory_size) | ||
| dist_dir = repo_root / "dist" | ||
| dist_dir = paths.dist_dir() | ||
|
|
Comment on lines
71
to
73
| # Install into staging. | ||
| build_mod.install( | ||
| sysroot, |
ppenna
reviewed
Jun 9, 2026
ada-x64
force-pushed
the
fix/release-v0.11.1
branch
from
10a35d1 to
303da22
Compare
ppenna
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR packages the release artifacts to
paths.dist_dir(). Makes minimal code changes.Also removes extraneous build from the release process.