deps(deps): update phpseclib/phpseclib requirement from ^3.0 to ^3.0 || ^4.0

composer.json

@@ -29,7 +29,7 @@
     },
     "require": {
         "php": ">=8.1",
-        "phpseclib/phpseclib": "^3.0"
+        "phpseclib/phpseclib": "^3.0 || ^4.0"
     },
     "require-dev": {
         "phpunit/phpunit": "^10.5",

src/BCMath.php

@@ -182,10 +182,7 @@
     {
         $parts = explode('.', $num);
 
-        // Ensure both parts exist
-        if (!isset($parts[1])) {
-            $parts[1] = '';
-        }
+        $parts[1] ??= '';
 
         return [$parts[0], $parts[1]];
     }
@@ -198,20 +195,20 @@
      *
      * @return array{0: BigInteger, 1: BigInteger, 2: int} Array containing [num1Big, num2Big, maxPad]
      */
     protected static function prepareBigIntegerInputs(string $num1, string $num2): array
     {
         // Parse decimal numbers
         [$num1Int, $num1Dec] = self::parseDecimalNumber($num1);
         [$num2Int, $num2Dec] = self::parseDecimalNumber($num2);
 
         // Pad decimal parts to same length
-        $maxPad = max(strlen((string) $num1Dec), strlen((string) $num2Dec));
-        $num1Dec = str_pad((string) $num1Dec, $maxPad, '0');
-        $num2Dec = str_pad((string) $num2Dec, $maxPad, '0');
+        $maxPad = max(strlen($num1Dec), strlen($num2Dec));
+        $num1Dec = str_pad($num1Dec, $maxPad, '0');
+        $num2Dec = str_pad($num2Dec, $maxPad, '0');
 
         // Convert to BigInteger for calculation
         $num1Big = new BigInteger($num1Int.$num1Dec);
         $num2Big = new BigInteger($num2Int.$num2Dec);
 
         return [$num1Big, $num2Big, $maxPad];
     }
@@ -222,7 +219,7 @@
      * Applies scale formatting and zero normalization. Implements Phase 5
      * of the standard processing pattern for most arithmetic operations.
      */
     protected static function formatFinalResult(BigInteger $result, int $scale, int $pad = 0): string
     {
         $formatted = self::format($result, $scale, $pad);
 
@@ -344,23 +341,23 @@
      *
      * @return BigInteger[] Array containing [num1Big, num2Big]
      */
     private static function prepareForComparison(string $num1, string $num2, int $scale): array
     {
         // Parse decimal numbers
         [$num1Int, $num1Dec] = self::parseDecimalNumber($num1);
         [$num2Int, $num2Dec] = self::parseDecimalNumber($num2);
 
         // Apply scale truncation and padding
-        $num1Dec = substr((string) $num1Dec, 0, $scale);
-        $num2Dec = substr((string) $num2Dec, 0, $scale);
+        $num1Dec = substr($num1Dec, 0, $scale);
+        $num2Dec = substr($num2Dec, 0, $scale);
 
         // Pad decimal parts to the same length (scale)
         $num1Dec = str_pad($num1Dec, $scale, '0', STR_PAD_RIGHT);
         $num2Dec = str_pad($num2Dec, $scale, '0', STR_PAD_RIGHT);
 
         // Convert to BigInteger for comparison
         $num1Big = new BigInteger($num1Int.$num1Dec);
         $num2Big = new BigInteger($num2Int.$num2Dec);
 
         return [$num1Big, $num2Big];
     }
@@ -415,10 +412,10 @@
      *
      * Places the decimal place at the appropriate place, adds trailing 0's as appropriate, etc
      */
     public static function format(BigInteger $x, ?int $scale = null, int $pad = 0): string
     {
         $sign = self::isNegative($x) ? '-' : '';
         $x = str_replace('-', '', (string) $x);
 
         if (strlen($x) !== $pad) {
             $x = str_pad($x, $pad, '0', STR_PAD_LEFT);
@@ -695,9 +692,7 @@
 
         // Phase 4: Number processing
         $baseParts = explode('.', $base);
-        if (!isset($baseParts[1])) {
-            $baseParts[1] = '';
-        }
+        $baseParts[1] ??= '';
 
         // Pad decimal parts
         $maxPad = strlen($baseParts[1]);
@@ -768,10 +763,7 @@
         self::validateNumberString($exponent, 'bcpowmod', 2, 'exponent');
         self::validateNumberString($modulus, 'bcpowmod', 3, 'modulus');
 
-        // Phase 2: Scale resolution and validation
-        if ($scale === null) {
-            $scale = 0;
-        }
+        $scale ??= 0;
         self::validateScale($scale, 'bcpowmod', 4);
 
         // Phase 3: Number processing and validation
@@ -1174,7 +1166,7 @@
         $result = self::placeDecimalPoint($roundedInt, $precision);
 
         if ($sign === -1 && !$isZero) {
-            $result = '-'.$result;
+            return '-'.$result;
         }
 
         return $result;