Skip to content

fix(skills): move builtin skill replace out of the overflow menu - #2369

Open
jsers wants to merge 1 commit into
mainfrom
fix/skills-builtin-replace
Open

jsers wants to merge 1 commit into
mainfrom
fix/skills-builtin-replace

Conversation

@jsers

@jsers jsers commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Builtin non-git skills exposed "Replace" only inside the overflow dropdown. Surface it as a standalone toolbar button instead, matching the builtin git skill entry, and restrict the overflow menu to non-builtin skills.

Summary by CodeRabbit

  • Updates
    • Built-in skills no longer show an overflow menu. Eligible admins can replace built-in skills using a button beside the toolbar or in the update controls for Git-based skills.
    • For skills with an overflow menu, download is available, while replace and delete actions are shown only when the skill can be modified.

Builtin non-git skills exposed "Replace" only inside the overflow dropdown.
Surface it as a standalone toolbar button instead, matching the builtin git
skill entry, and restrict the overflow menu to non-builtin skills.
Copilot AI lite review requested due to automatic review settings September 23, 2026 06:10
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 797e77c0-8511-4a90-95c7-65ddeb4b4620

📥 Commits

Reviewing files that changed from the base of the PR and between 1bdb1e2 and 6302eaf.

📒 Files selected for processing (1)
  • src/pages/aiConfig/skills/pages/SkillDetailPanel.tsx

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The skill detail panel now hides the overflow menu for builtin skills and shows their replace action as a dedicated upload button. The overflow menu always includes download, and shows replace and delete actions based on canModify.

Changes

Skill detail actions

Layer / File(s) Summary
Builtin skill action controls
src/pages/aiConfig/skills/pages/SkillDetailPanel.tsx
Builtin non-git skills show a replace button for admins. Builtin git skills use the same button in the update group. Builtin skills do not show the overflow menu. The menu always includes download and gates replace and delete on canModify.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: 710leo

Merge Risk: ⚪ Minimal · up to 6302e

Builtin replacement moves to a dedicated button without changing who can replace, download, or delete skills. No actionable merge risk remains after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: moving the builtin skill Replace action out of the overflow menu.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Moves builtin non-Git skill replacement from the overflow menu to a standalone toolbar button.

Changes:

  • Adds a standalone Replace button for builtin skills.
  • Restricts overflow actions to non-builtin skills.
  • Preserves builtin Git update and replacement behavior.
File Description
src/​pages/​aiConfig/​skills/​pages/​SkillDetailPanel.tsx Updates toolbar and overflow-menu action visibility.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants