fix(nodes-langchain): strip internal stack traces from MCP trigger error responses#28499
Open
SAY-5 wants to merge 1 commit inton8n-io:masterfrom
Open
fix(nodes-langchain): strip internal stack traces from MCP trigger error responses#28499SAY-5 wants to merge 1 commit inton8n-io:masterfrom
SAY-5 wants to merge 1 commit inton8n-io:masterfrom
Conversation
…ror responses Per n8n-io#28414, MessageFormatter.formatError() in the MCP Trigger node appends the full server-side stack trace to the tool error response that gets sent back to the MCP client over JSON-RPC. Stack traces are internal implementation details and should not leak to clients. Return only `name: message` in the response. The existing call site in McpServer.ts already logs the full error server-side for debugging.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #28414,
MessageFormatter.formatError()in the MCP Trigger node appends the full server-side stack trace to the tool error response that gets sent back to the MCP client over JSON-RPC. Stack traces are internal implementation details and should not leak to clients.This PR returns only
name: messagein the response. The existing call site inMcpServer.tsalready logs the full error server-side for debugging, so no observability is lost.Closes #28414