Show demo connect guard for demo users launching the widget on non-demo institutions#328
Open
mwclemy wants to merge 1 commit into
Open
Show demo connect guard for demo users launching the widget on non-demo institutions#328mwclemy wants to merge 1 commit into
mwclemy wants to merge 1 commit into
Conversation
mwclemy
requested review from
Jameson13B,
ash-wright123,
codingLogan and
wesrisenmay-mx
as code owners
| institution = {}, | ||
| experimentalFeatures = {}, | ||
| widgetProfile, | ||
| user = {}, |
Collaborator
There was a problem hiding this comment.
I don't love having to pass something(the user) all over the place when we already have it stored somewhere in Redux.
We can use a thunk to grab the user from the state instead of passing it around.
|
|
||
| if (shouldStepToInstitutionStatusDetails) { | ||
| return STEPS.INSTITUTION_STATUS_DETAILS | ||
| } else if (shouldStepToDemoConnectGuard) { |
Collaborator
There was a problem hiding this comment.
We're going to need to have E2E tests for this functionality when we make the changes to the MX connect widget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
current_institution_guid,current_institution_code, orcurrent_member_guidon initial load.