Fix shortcut drag-reorder and duplicate prevention

[dmoo500]

Summary

Fixes two shortcut-related bugs:

1. Drag-reorder failure: Reordering shortcuts failed when the stored preference URI differed from the item's current URI
2. Duplicate shortcuts: Same item could appear multiple times in sidebar due to identity mismatches

Changes

• NavShortcuts.vue: Use findPinnedUriForItem() to look up actual stored URIs for drag-reorder (instead of constructing new ones)
• useShortcuts.ts:
  • Introduce isUriMatchingItem() helper for provider-mappings-aware URI-to-item matching
  • Export findPinnedUriForItem() for components that need to resolve stored URIs
  • Update pinShortcutStandalone() to check identity match (not just exact URI)
  • Add Set-based deduplication in pinnedItems computed
  • Restore original findPinnedUriByIdentities() implementation to minimize diff

Testing

• ✅ Drag-reorder shortcuts works correctly (even when stored URI differs from item URI)
• ✅ No duplicate shortcuts appear in sidebar
• ✅ Context menu shows correct pinned state
• ✅ All useShortcuts tests pass (9 tests)

Related Issues

Fixes bugs identified by @stvncode in review.

[Copilot]

Pull request overview

This PR fixes shortcut “pinned item” identity matching so that provider-instance items (e.g., smart playlists pinned from recommendation rows) consistently resolve and appear in the sidebar. It aligns the shortcut system’s matching logic around provider mappings/identities instead of relying on direct URI equality in some code paths.

Changes:

• Introduces a unified isUriMatchingItem() helper that matches a pinned URI against an item using identity matching via provider_mappings.
• Replaces several URI-vs-item comparisons (watch filtering, pin/unpin flow, update event handling, sidebar resolution) to use the unified helper.
• Removes the now-unused findPinnedUriByIdentities() helper and simplifies related exported helpers.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[stvncode]

• Drag-reorder in NavShortcuts.vue (line 163–168) silently fails for shortcuts whose stored URI differs from the resolved item's URI
• Duplicate-identity preference entries (legacy state from this very bug, or newly created via pinShortcutStandalone) render the same item twice with duplicate :keys via the new pinnedItems matching

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/composables/useShortcuts.ts:413

• unpinItem removes resolvedItems using identity matching, but it still updates the stored pinnedUris via isSameShortcutUri(u, uri). If uri is an equivalent URI (e.g. provider instance/domain or a URI that only matches through provider_mappings), the preference entry may not be removed and the watch() will re-resolve/re-add the item, leaving the shortcut effectively pinned.

    await setPreference(
      PREF_KEY,
      pinnedUris.value.filter((u) => !isSameShortcutUri(u, uri)),
    );

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/composables/useShortcuts.ts:288

• findPinnedUriForItem is now exported and used for reorder operations, but there is no test coverage for its identity matching behavior (especially around provider_mappings/provider-instance vs provider-domain). Since there are already standalone helper tests for this module, adding a focused test would help prevent regressions.

export function findPinnedUriForItem(
  item: ShortcutItem | ItemMapping,
): string | null {
  const identities = getShortcutIdentities(item);
  return findPinnedUriByIdentities(identities, _getPinnedUris());

src/composables/useShortcuts.ts:407

• The new identity-based matching can cause multiple pinned URIs that represent the same underlying shortcut (e.g. encoded vs raw, provider-domain vs provider-instance) to collapse to a single displayed item later (see pinnedItems dedupe). However, pinnedUris still retains duplicates, which can inflate the shortcut count (MAX_SHORTCUTS/cap checks) and make it impossible to pin new items even though fewer are shown. Consider normalizing/deduping pinnedUris on change using the same parsed identity key (decoded itemId + base provider).

  watch(pinnedUris, async (newUris) => {
    const currentItems = resolvedItems.value;

[dmoo500]

Fixed both issues:

1. Drag-reorder: Now exports findPinnedUriForItem() so NavShortcuts can look up the actual stored preference URIs (instead of constructing new ones from the resolved item). This ensures reordering works even when the stored URI differs from the item's current URI.

2. Duplicate shortcuts:

   • pinShortcutStandalone() now checks identity match (provider_mappings aware) instead of just exact URI match
   • pinnedItems computed uses a Set to deduplicate before rendering

Also restored the original findPinnedUriByIdentities() implementation from main to minimize the diff.

[stvncode]

Thanks @dmoo500 🙏