Skip to content

✨ Open the Slurm-allocated QDMI device - #2025

Open
burgholzer wants to merge 6 commits into
mainfrom
agent/qdmi-allocated-device
Open

✨ Open the Slurm-allocated QDMI device#2025
burgholzer wants to merge 6 commits into
mainfrom
agent/qdmi-allocated-device

Conversation

@burgholzer

@burgholzer burgholzer commented Aug 9, 2026

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

Description

Add a focused FoMaC entry point for opening the QDMI device that Slurm already allocated to the current job:

  • Session::openAllocatedDevice(overrides) in C++
  • mqt.core.fomac.open_allocated_device(...) in Python

The implementation reads SLURM_JOB_LICENSES, matches exactly one local static Slurm license to a registered stable QDMI device ID, requires a count of one, opens a fresh device session with optional job-specific configuration overrides, and checks that the device reports IDLE or BUSY. Unrelated licenses are ignored; ambiguous, malformed, OR, remote-license, and unavailable-device cases fail explicitly.

This is intentionally a separate, scheduler-facing PR. It does not introduce a broker, lease service, resource group, or new SPANK behavior.

Validation

  • allocated-device native tests (4/4 passed)
  • focused Python tests (8/8 passed)
  • prek on all changed files
  • prior full branch lint before the current-main merge

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added an entry to the changelog.
  • I have added migration instructions to the upgrade guide (not needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the local checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

@burgholzer burgholzer added feature New feature or request QDMI Anything related to QDMI labels Aug 9, 2026
@burgholzer burgholzer self-assigned this Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.77108% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fomac/FoMaC.cpp 81.4% 5 Missing ⚠️
src/qdmi/driver/Driver.cpp 98.2% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mergify mergify Bot added the conflict label Aug 9, 2026
@burgholzer
burgholzer force-pushed the agent/qdmi-allocated-device branch from 8c20395 to e57e8ca Compare August 9, 2026 22:25
@mergify mergify Bot removed the conflict label Aug 9, 2026
@burgholzer burgholzer added this to the QDMI Support milestone Aug 9, 2026
@mergify mergify Bot added the conflict label Aug 10, 2026
@burgholzer
burgholzer force-pushed the agent/qdmi-allocated-device branch from e57e8ca to 0326808 Compare August 10, 2026 16:17
@mergify mergify Bot removed the conflict label Aug 10, 2026
@mergify mergify Bot added the conflict label Aug 10, 2026
@burgholzer burgholzer added c++ Anything related to C++ code python Anything related to Python code and removed conflict labels Aug 10, 2026
@mergify mergify Bot added the conflict label Aug 10, 2026
@burgholzer
burgholzer force-pushed the agent/qdmi-allocated-device branch from d5c3a75 to 489939d Compare August 10, 2026 20:09
@mergify mergify Bot removed the conflict label Aug 10, 2026
@burgholzer
burgholzer force-pushed the agent/qdmi-allocated-device branch from 489939d to 00c8012 Compare August 10, 2026 22:39
@burgholzer
burgholzer force-pushed the agent/qdmi-allocated-device branch from 00c8012 to 962c851 Compare August 11, 2026 00:15
@mergify mergify Bot added the conflict label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code conflict feature New feature or request python Anything related to Python code QDMI Anything related to QDMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant