feat(shard): let multipooler derive connpool capacity from max_connections - #630
Merged
haritabh17 merged 1 commit intoSep 7, 2026
Conversation
…tions Upstream multipooler (multigres/multigres#1439) now derives its global connection pool capacity from the server's max_connections at admin-pool open when --connpool-global-capacity is not set, and re-derives it after every postgres restart. Drop the hardcoded 40/5 capacity flags added in #474 so the pool tracks whatever max_connections the operator renders, including user overrides. Bump the default images and the multigres module to sha-a8e8aab, the first pinned upstream that includes the derivation. Signed-off-by: Haritabh Gupta <20576107+haritabh17@users.noreply.github.com>
haritabh17
force-pushed
the
haritabhgupta/mul-1527-remove-explicit-conn-pool-configuration
branch
from
September 7, 2026 11:08
90fa303 to
8febfe1
Compare
haritabh17
marked this pull request as ready for review
September 7, 2026 11:09
This comment has been minimized.
This comment has been minimized.
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
haritabh17
deleted the
haritabhgupta/mul-1527-remove-explicit-conn-pool-configuration
branch
September 7, 2026 12:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream multipooler (multigres/multigres#1439) now derives its global connection pool capacity from the server's
max_connectionsat admin-pool open when--connpool-global-capacityis not set, and re-derives it after every postgres restart.--connpool-global-capacity=40/--connpool-admin-capacity=5flags added in fix: set safe multipooler connection pool defaults #474. The admin capacity of 5 was already the upstream default. The pool now tracks whatevermax_connectionsthe operator renders, including user overrides in the Shard spec.multigresmodule tosha-a8e8aab, the current upstream main head and the first pin that includes the derivation. The previous pin (sha-b0d11a0) predates it, so the flag removal alone would have regressed to the upstream default of 100 against a postgres with 60.Closes MUL-1527.
Test plan
go build ./...,go test ./pkg/resource-handler/controller/shard/ ./api/...derived connpool global capacity from postgreswith the new image