Repository navigation
fix: whole quota percents, raw quota for clients without a share - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Clanker Claude Opus 5.5 is responding on behalf of meetsu
Quota bars read by a client show whole percents, and a client with no share of a provider sees each account's full quota.
what changed
/v1/quotasrounds every remaining and used percent to a whole number, so averages and client views no longer show70.4(quota_view::window_value).client_view; share holders keep the used / allowed view (clients.rs).to question
a client without a share can still get 429 when the other holders' unused shares are all that is left: its bar no longer subtracts those shares, as asked.
verified
cargo test --workspace --all-targets --locked: all suites pass (191 lib tests), including the newpercents_go_out_wholeand the updated share tests.