Repository navigation
KeyTips: plain access-key targets join the root level (compose-both) - #78
Merged
Merged
Conversation
…both) With the overlay owning Alt whenever a bar exists, a page's own access keys were unreachable: the cue is suspended while badges show, and (since #72) the access-key stage stands down. The active scope's plain access-key targets — check boxes, buttons, labels; anything the manager registered that is not inside a badged bar — now join the overlay's ROOT level with their mnemonic as the badge (AccessKeyManager.EligibleTargetsInActiveScope, document order). Inline placement puts the badge where the cue would be and the cue stays suspended, so nothing draws twice. Collisions go through the one policy: an explicit key wins, colliding auto letters are suffixed — a content letter beside a tab letter (B0 the tab, B1 the check box), and content targets that would multi-match under the manager, which activate directly instead of focus-cycling. Deeper levels stay bar-only. Controls inside a badged bar are not badged again at the root. KeyTipPlainTargetTests; design doc §14. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013qbF5ru6uh5w7fqhP3yoPE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compose-both, as agreed: with the overlay owning Alt whenever a bar exists, a page's own access keys were unreachable (cue suspended while badges show; the access-key stage stands down since #72).
The active scope's plain access-key targets — check boxes, buttons, labels; anything the manager registered that is not inside a badged bar — now join the overlay's root level with their mnemonic as the badge (
AccessKeyManager.EligibleTargetsInActiveScope, document order). Inline placement puts the badge where the cue would be and the cue stays suspended, so nothing draws twice.Collisions go through the one policy: an explicit key wins, colliding auto letters are suffixed — a content letter beside a tab letter (
B0the tab,B1the check box, document order), and content targets that would multi-match under the manager, which activate directly instead of focus-cycling. Deeper levels stay bar-only, and controls inside a badged bar are not badged again at the root.Tests (
KeyTipPlainTargetTests, four of five fail without the feature): page check box + button badged beside the tab, inline over the mnemonic with the underline cue suspended, toggle/click on activation; tab-vs-content collision both ways; multi-match → suffixes; a label badge focusing its target; bar controls not duplicated at the root. Bars 327 / UI access-key sections green.🤖 Generated with Claude Code
https://claude.ai/code/session_013qbF5ru6uh5w7fqhP3yoPE