Skip to content

arm64: add support for MSM8920, add support for motorola-perry - #48

Draft
agrecascino wants to merge 3 commits into
msm89x7-mainline:msm89x7/6.19.5from
aaaaaaaaaaaaaaaaaaaaaaaaaay:msm89x7/6.19.5
Draft

arm64: add support for MSM8920, add support for motorola-perry#48
agrecascino wants to merge 3 commits into
msm89x7-mainline:msm89x7/6.19.5from
aaaaaaaaaaaaaaaaaaaaaaaaaay:msm89x7/6.19.5

Conversation

@agrecascino

Copy link
Copy Markdown

It's here. The future of computing. A low end phone from 2016.

Implement reset GPIO handling logic for the rmi_i2c driver. This logic
is required for some mobile devices to successfully initialize the touch
controller.

As there are no datasheets available, the timings were taken from the
GPLv2+ licensed synaptics-dsx-v2.1 vendor driver release.

Tested-On: Motorola G5 Plus (Potter / XT1685)

Signed-off-by: Felix Kaechele <felix@kaechele.ca>
Comment thread arch/arm64/boot/dts/qcom/msm8920.dtsi Outdated
Comment thread arch/arm64/boot/dts/qcom/msm8920.dtsi Outdated
Comment thread arch/arm64/boot/dts/qcom/msm8920.dtsi Outdated
Comment thread drivers/clk/qcom/clk-smd-rpm.c
@barni2000

Copy link
Copy Markdown
Collaborator

Please remove the panel commit and open PR here https://github.com/msm89x7-mainline/linux-panel-drivers/pulls

@barni2000

Copy link
Copy Markdown
Collaborator

Add add proper descriptions and your SoB for your commits

MSM8920 is essentially MSM8917 with MSM8953's modem stack.
It has bigger modem firmwares that require larger memory regions,
IPA, and therefore a slightly different clock situation.
We hook up the clocks for IPA, and add the corresponding nodes
to a new dtsi.

Signed-off-by: Catherine Frederick (coolguy) <serenity@floorchan.org>
Add initial support for the Motorola Moto E4 (perry)

Signed-off-by: Catherine Frederick (coolguy) <serenity@floorchan.org>

@barni2000 barni2000 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate rpmcc changes and send it to upstream. Also send an initial 8920 support with perry to upstream.
I will wait with merge until that.

@@ -0,0 +1,28 @@
// SPDX-License-Identifier: BSD-3-Clause
/*
* Copyright (c) 2025 Val Packett

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add your copy right here

@@ -0,0 +1,32 @@
// SPDX-License-Identifier: BSD-3-Clause
/*
* Copyright (c) 2025 Val Packett

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add your copy right here

@@ -0,0 +1,32 @@
// SPDX-License-Identifier: BSD-3-Clause

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPL-2.0-only since msm8917.dtsi also licensed by that

@@ -0,0 +1,28 @@
// SPDX-License-Identifier: BSD-3-Clause

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPL-2.0-only since msm8917.dtsi also licensed by that

@@ -0,0 +1,55 @@
// SPDX-License-Identifier: BSD-3-Clause

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPL2.0-only

status = "okay";

panel@0 {
compatible = "motorola,perry-499v1-tianma";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do this device have only 1 panel variant?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old PR but I want to note that my Moto E4 (perry) has an Ofilm panel.

status = "okay";
};

&pm8937_spmi_regulators {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as i know 8917 is not need this

output-high;
};

mdss_dsi_sleep: mdss-dsi-sleep-state {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

bias-pull-up;
};

mdss_dsi_default: mdss-dsi-default-state {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mdss_dsi_default: mdss-dsi-default-state {
panel_default: panel-default-state {


&wcd_codec {
qcom,hphl-jack-type-normally-open;
qcom,mbhc-vthreshold-high = <75 150 225 450 500>;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link relevant part from msm8952.c?

@barni2000
barni2000 marked this pull request as draft July 13, 2026 21:34
@aneesh-pradhan

Copy link
Copy Markdown

Adoption note (DCO / CONTRIBUTING): we’re picking up this stalled series from Project Xylitol (postmarketOS on XT1765 / perry). Original authors remain credited via existing Signed-off-by lines; new re-rolls will add our SoB.

Hardware evidence since this draft:

Planned re-roll order (matches barni2000’s gate + CONTRIBUTING upstream-first for shared files):

  1. Split rpmcc-msm8920 (+ bindings) as its own upstream-aimed series
  2. Minimal msm8920.dtsi (drop no-op overrides vs current msm8917.dtsi; address MSS/IPA evidence question)
  3. Refresh perry DTS (review fixes: pinctrl on panel node, licenses, non-exec bits, multi-panel note) as a new PR if this draft stays unmoved
  4. Keep panels in linux-panel-drivers (not this tree)

Won’t force-push this branch; expect a replacement series. Tracking: https://github.com/aneesh-pradhan/xylitol/issues/13

@aneesh-pradhan

Copy link
Copy Markdown

Picking this up as discussed — re-rolled against current msm89x7/7.1.3 addressing @barni2000's review comments (rpmcc split, memory overrides, panel pinctrl/nora match, GPL-2.0, etc.). Original authorship (Catherine Frederick / coolguy for DTS+rpmcc; Felix Kaechele for rmi_i2c) is preserved.

Superseding PR: #57

Panels (Tianma + Ofilm) are in linux-panel-drivers#8. Happy to close this once #57 is preferred, or force-push onto this branch if that's cleaner for maintainers.

@aneesh-pradhan

Copy link
Copy Markdown

Upstream sends for the merge gate (barni2000 review) are now on-list via linux-arm-msm:

Gate 3 — rpmcc MSM8920 (binding + clk-smd-rpm):

Gate 4 — initial MSM8920 + perry DTS (trimmed mainline-first subset; depends on rpmcc):

Panel remains in linux-panel-drivers; IPA / QDSP6 audio / FG / modem deferred until their mainline dependencies exist. Happy to re-roll either series from review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants