Skip to content

fix: replace unsupported JSON Schema contains with enum in rule option schema - #514

Merged
mskelton merged 1 commit into
mskelton:mainfrom
andreww2012:fix/no-hooks-options-schema
Sep 29, 2026
Merged

mskelton merged 1 commit into
mskelton:mainfrom
andreww2012:fix/no-hooks-options-schema

Conversation

@andreww2012

Copy link
Copy Markdown
Contributor

I noticed that currently items option of the no-hooks rule allows any value.

That's because contains JSON Schema keyword is not supported in at least ESLint 10, so I replaced it with items, which is supported in all ESLint versions the plugin states compatibility with.

Tiny side change: I've added MacOS' .DS_Store to .gitignore.

@mskelton
mskelton merged commit 4f35eb6 into mskelton:main Sep 29, 2026
1 check passed
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 2.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants