ファイル分割リファクタ: 責務ごとにモジュール分離 (挙動変更なし) - #20
Merged
Merged
Conversation
- HTMLFormatter の基本要素出力を固定する特性テスト20件 - 変更行ハイライト (changedLines) の挙動固定テスト9件 (DiffCalculator統合含む) - KeyBindingHandler のディスパッチ/パススルー契約テスト10件 (Command-C/A のコピー保護) - String.htmlEscaped テスト3件 - テーブルヘッダの th/td 誤判定バグを XCTExpectFailure で記録 (修正PRで反転予定) - FileWatcher に監視間隔の引数注入を追加 (デフォルト0.5秒で挙動不変) し、テストの Thread.sleep 依存を短縮してフレーク対策 Co-authored-by: Claude Code <claude@anthropic.com>
- project.yml を単一情報源として pbxproj を生成 (生成物もコミット) - Xcode側にユニットテストターゲットを新設 (従来 xcodebuild test 不可だった) - バージョンを project.yml の MARKETING_VERSION/CURRENT_PROJECT_VERSION に一元化 (Info.plist はビルド設定変数を参照。1.5/1.7 の二重管理不整合を解消) - CI に xcodegen 整合性チェックと xcodebuild test を追加 - README の古い手動セットアップ手順を XcodeGen ベースに更新 - プロジェクト名/スキーム名/構成は維持し make build/install の互換性を保持 Co-authored-by: Claude Code <claude@anthropic.com>
Co-authored-by: Claude Code <claude@anthropic.com>
Co-authored-by: Claude Code <claude@anthropic.com>
…eet/String拡張) MarkdownWebView.swift は745行から258行に。未使用だった HTMLFormatter.format(_:) は削除。 Co-authored-by: Claude Code <claude@anthropic.com>
Co-authored-by: Claude Code <claude@anthropic.com>
MarkdownViewerTests.swift に5スイートが連結され import が重複していたのを解消。 Co-authored-by: Claude Code <claude@anthropic.com>
Co-authored-by: Claude Code <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
デグレ防止シリーズ PR 4/5。1ファイルに複数の責務が同居していた構造を分割する。挙動変更なし (特性テスト75件が全コミットでグリーン維持)。
変更内容 (1コミット = 1抽出)
DiffCalculator.swiftInput/KeyBindingHandler.swiftInput/DefaultKeyBindings.swiftRendering/HTMLFormatter.swiftRendering/FrontmatterRenderer.swiftRendering/MarkdownStylesheet.swiftRendering/String+HTMLEscaping.swiftLaunchArgumentParser.swiftHTMLFormatter.format(_:)を削除検証
swift testグリーン (最終 81件)xcodebuild build -configuration Release: 成功swiftlint: exit 0Base: #19 (chore/xcodegen)
🤖 Generated with Claude Code
https://claude.ai/code/session_01YAgg3ad7Muz4ed4EYTgKU2