Repository navigation
fix(repo): make the pre-commit hook executable - #8
Merged
Merged
Conversation
The hook was committed with mode 100644. Git skips a hook without the executable bit, so the branch guard and scripts/format.sh never ran on commit in any clone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/git-hooks/pre-commitwas committed with mode100644. Git skips a hook without the executable bit and printshint: The 'scripts/git-hooks/pre-commit' hook was ignored because it's not set as executable, so the branch guard andscripts/format.shnever ran on commit in any clone.What changed
The file mode is
100755. The content is unchanged.Verification
git ls-files -s scripts/git-hooks/pre-commitshows100755.Per-task commits before collapse