Various improvements to secret template html file - #31
Open
gamedevsam wants to merge 3 commits into
Open
Conversation
gamedevsam
commented
Jan 6, 2023
- Hide password hint when no hint is provided.
- Decrypt contents when users press enter key.
- Use password input type with checkbox to display text characters.
Owner
|
@gamedevsam thank you very much for this contribution. Unfortunately at the moment I'm pretty squeezed and I doubt I'll have time to review and accept. Details here: #29 |
Author
|
No worries at all, everyone understands where you're coming from. If this project continues to get interest you might want to consider handing off the reigns to someone else who's interested and has the bandwidth to maintain it. For anyone else interested in using Portable Secret using the improvements made in this PR you can use it on my website: https://sambatista.com/secret |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.