Skip to content

fix(json tree): update toggle to be controlled #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
collectedmind merged 1 commit into from
Apr 16, 2026
Merged

fix(json tree): update toggle to be controlled #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion ui/components/dev-panel-sources/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import style from "./style.module.css"

import { useRef, useState } from "react"
import { useEffect, useRef, useState } from "react"
import { JsonNode } from "../dev-panel-tree"
import {
SOURCE_TTL_MS,
Expand Down Expand Up @@ -171,15 +171,28 @@ function SourceRow({

const cardRef = useRef<HTMLDivElement>(null)
const [treeExpanded, setTreeExpanded] = useState(false)
const programmaticToggle = useRef(false)

const toggleTree = () => {
const next = !treeExpanded
programmaticToggle.current = true
cardRef.current?.querySelectorAll("details").forEach((d) => {
d.open = next
})
programmaticToggle.current = false
setTreeExpanded(next)
}

useEffect(() => {
const card = cardRef.current
if (!card) return
const reset = () => {
if (!programmaticToggle.current) setTreeExpanded(false)
}
card.addEventListener("toggle", reset, true)
return () => card.removeEventListener("toggle", reset, true)
}, [])

const dataEntries =
data !== undefined && typeof data === "object" && data !== null
? Object.entries(data as Record<string, unknown>)
Expand Down
Loading