Repository navigation
Bug 2078656 - Fix firefox-prefs tools and migrate them to BiDi - #202
Merged
Merged
Conversation
hbenl
force-pushed
the
bug2078656
branch
2 times, most recently
from
October 6, 2026 15:46
1933458 to
0b34199
Compare
juliandescottes
left a comment
juliandescottes
left a comment
Collaborator
There was a problem hiding this comment.
Just one comment about error handling, but otherwise this looks fine to me, thanks!
Comment on lines
107
to
112
Collaborator
There was a problem hiding this comment.
With the new getPrivilegedContext helper, I think we will no longer hit this branch when MOZ_REMOTE_ALLOW_SYSTEM_ACCESS is not set.
The error will be swallowed in getPrivilegedContext and we will throw an error which doesn't preserve the original message with UnsupportedOperationError.
Maybe we can drop this try/catch? Same comment for getFirefoxPrefsTool
juliandescottes
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this PR shares a commit with #201, so it'll have to be rebased after merging that PR.