Skip to content

don't clone the encdec in the logins sync engine#7478

Merged
jo merged 1 commit into
mozilla:mainfrom
jo:login-sync-engine-encdec
Jul 16, 2026
Merged

don't clone the encdec in the logins sync engine#7478
jo merged 1 commit into
mozilla:mainfrom
jo:login-sync-engine-encdec

Conversation

@jo

@jo jo commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

tested on desktop side

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@jo
jo force-pushed the login-sync-engine-encdec branch from eb8a376 to e51c2ba Compare July 16, 2026 10:10
@jo
jo requested a review from bendk July 16, 2026 10:11

@bendk bendk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me. Like I was mentioning in slack, maybe you want to see if this fixes the issues on Desktop with a try run. I'll approve now and let you make the call on when to merge.

@jo
jo force-pushed the login-sync-engine-encdec branch from e51c2ba to 8816475 Compare July 16, 2026 15:51
@jo
jo enabled auto-merge July 16, 2026 15:51
@jo
jo added this pull request to the merge queue Jul 16, 2026
Merged via the queue into mozilla:main with commit d8249ad Jul 16, 2026
14 checks passed
@jo
jo deleted the login-sync-engine-encdec branch July 16, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants