don't clone the encdec in the logins sync engine#7478
Merged
Conversation
jo
force-pushed
the
login-sync-engine-encdec
branch
from
July 16, 2026 10:10
eb8a376 to
e51c2ba
Compare
bendk
approved these changes
Jul 16, 2026
bendk
left a comment
Contributor
There was a problem hiding this comment.
This looks right to me. Like I was mentioning in slack, maybe you want to see if this fixes the issues on Desktop with a try run. I'll approve now and let you make the call on when to merge.
jo
force-pushed
the
login-sync-engine-encdec
branch
from
July 16, 2026 15:51
e51c2ba to
8816475
Compare
jo
enabled auto-merge
July 16, 2026 15:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested on desktop side
Pull Request checklist
[ci full]to the PR title.