Skip to content

Make Login::shutdown release its EncryoptorDecryptor#7476

Merged
jo merged 1 commit into
mozilla:mainfrom
jo:borrow-encdec
Jul 15, 2026
Merged

Make Login::shutdown release its EncryoptorDecryptor#7476
jo merged 1 commit into
mozilla:mainfrom
jo:borrow-encdec

Conversation

@jo

@jo jo commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

to avoid leaks from foreign providers of the encryptor decryptor trait.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

to avoid leaks from foreign providers of the encryptor decryptor trait.
@jo jo force-pushed the borrow-encdec branch from 00062dd to a5b788f Compare July 15, 2026 17:19
@jo jo requested a review from bendk July 15, 2026 17:20

@bendk bendk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, let's hope it fixes the moz-central errors.

@jo jo enabled auto-merge July 15, 2026 17:22
@jo jo added this pull request to the merge queue Jul 15, 2026
Merged via the queue into mozilla:main with commit 7304877 Jul 15, 2026
14 checks passed
@jo jo deleted the borrow-encdec branch July 15, 2026 18:04
jo added a commit to jo/application-services that referenced this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants