Skip to content

ci: no Windows job, so Windows regressions are never caught #312

Description

@peteski22

No CI job runs on Windows, so Windows regressions are invisible.

Every workflow is ubuntu-latest:

tests.yaml, golangci-lint.yaml, docs.yaml, deploy.yaml,
release.yaml, validate-registry.yaml, validate-goreleaser.yaml, validate-licenses.yaml

.goreleaser.yaml also builds linux and darwin only. Meanwhile #299 added internal/plugin/process_windows.go and internal/files/paths_windows_test.go already exists — we have Windows-specific code with zero automated coverage. Both Windows problems found while reviewing #299 were found by hand on a local Windows machine: the test-file breakage raised in that PR's review, and #311, which has been broken on main for some time.

Fix:

Worth settling before more Windows-specific code lands, otherwise //go:build windows files are only ever compiled by whoever happens to run them locally.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions