No CI job runs on Windows, so Windows regressions are invisible.
Every workflow is ubuntu-latest:
tests.yaml, golangci-lint.yaml, docs.yaml, deploy.yaml,
release.yaml, validate-registry.yaml, validate-goreleaser.yaml, validate-licenses.yaml
.goreleaser.yaml also builds linux and darwin only. Meanwhile #299 added internal/plugin/process_windows.go and internal/files/paths_windows_test.go already exists — we have Windows-specific code with zero automated coverage. Both Windows problems found while reviewing #299 were found by hand on a local Windows machine: the test-file breakage raised in that PR's review, and #311, which has been broken on main for some time.
Fix:
Worth settling before more Windows-specific code lands, otherwise //go:build windows files are only ever compiled by whoever happens to run them locally.
No CI job runs on Windows, so Windows regressions are invisible.
Every workflow is
ubuntu-latest:.goreleaser.yamlalso buildslinuxanddarwinonly. Meanwhile #299 addedinternal/plugin/process_windows.goandinternal/files/paths_windows_test.goalready exists — we have Windows-specific code with zero automated coverage. Both Windows problems found while reviewing #299 were found by hand on a local Windows machine: the test-file breakage raised in that PR's review, and #311, which has been broken onmainfor some time.Fix:
windows-latestto thetests.yamljob matrixWorth settling before more Windows-specific code lands, otherwise
//go:build windowsfiles are only ever compiled by whoever happens to run them locally.