Add preprocess scripts and preprocessing config - #434
Open
javiermtorres wants to merge 1 commit into
Open
javiermtorres wants to merge 1 commit into
javiermtorres wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Preprocessfunction can now be added, currently working only for image input models. The image processing information needed is loaded into the encoderfile, and added to the environment for Lua preprocessing. It is planned to be expanded in a further PR to allow features like custom sentence token breakup.@besaleli I'm not really satisfied about the whole structure, but it works right now (or at least the tests pass). Any comments or suggestions are welcome, specially on structuring assets (currently the image preproc config is its own asset; also, maybe an initial load as a Value and then coercion into a specific strongly-typed appropriate config type is more appropriate) and structuring the many related
typeclassestraits into a more consistent set.