ci: fix lint cache key and codecov upload on dependabot PRs - #950
Merged
Merged
Conversation
run-linter: with pre-commit-uv 4.2.1, uv 0.12.x records "version_info = 3.13" in a hook virtualenv's pyvenv.cfg while pre-commit compares it against the full "3.13.15", so every hook environment is reported unhealthy right after install and pre-commit aborts with "BUG: expected environment for python to be healthy immediately after install". pre-commit-uv 4.3.0 compares only the components uv recorded. Reproduced locally with 4.2.1 and confirmed fixed with 4.3.0 against this repo's hook config. The pre-commit and mypy cache keys now also carry the resolved CPython patch version, so a runner on a newer patch release no longer restores hook virtualenvs it has to discard and rebuild. run-unit-tests: dependabot branches do not receive repository secrets, so the empty Codecov token was rejected with "Token required because branch is protected" and failed the job. The upload is skipped when the token is empty. Uploads on normal PRs and on main are unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
njbrake
force-pushed
the
fix/ci-linter-cache-codecov
branch
from
September 21, 2026 14:08
f8616e1 to
0200e52
Compare
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two CI bugs blocking every dependabot PR.
run-linter: withpre-commit-uv4.2.1, uv 0.12.x writesversion_info = 3.13into a hook virtualenv'spyvenv.cfgwhile pre-commit expects3.13.15, so every hook env is unhealthy right after install. Not a cache problem; it reproduces with an empty cache. 4.3.0 compares only the components uv recorded. Cache keys now carry the patch version too.run-unit-tests: dependabot branches get no secrets, so the empty Codecov token was rejected ("Token required because branch is protected"). The upload is skipped when the token is empty; normal PRs and main unchanged.Both jobs now fail further along on dependency drift:
mcp2.x droppedstreamablehttp_clientand renamedinputSchema. Separate fix.PR Type
Relevant issues
None.
Checklist
AI Usage Information
AI Model used: Claude Opus 5 (1M context)
AI Developer Tool used: Claude Code
Any other info you'd like to share: The hook install failure was reproduced locally with
pre-commit-uv4.2.1 and confirmed fixed with 4.3.0, same uv 0.12.17 and this repo's hook config. In CI on this branch, all 14 hooks now install and run; only mypy fails, on the dependency drift noted above. Workflow syntax checked withactionlint.I am an AI Agent filling out this form (check box if true)
🤖 Generated with Claude Code