Skip to content

fix(ci): bump pinned Node 24.19.0 to 24.x (CVE-2026-111497) - #320

Open
bingenito wants to merge 1 commit into
mainfrom
fix/node-24-brotli-cve
Open

bingenito wants to merge 1 commit into
mainfrom
fix/node-24-brotli-cve

Conversation

@bingenito

Copy link
Copy Markdown
Member

The 2026-10-21 Node.js security release fixed CVE-2026-111497 (high-severity Brotli decoder out-of-bounds write, potential RCE) plus nine other CVEs across c-ares, OpenSSL, SQLite, and Undici. The patched 24.x line is v24.22.1; these workflows were pinned to 24.19.0, which predates the fix.

What changed

  • .github/workflows/deploy.yml — node-version: [24.19.0] → [24.x]
  • .github/workflows/pr-build.yml — node-version: [24.19.0] → [24.x]

How it was verified

  • A floating 24.x spec resolves to the latest 24.x patch (24.22.1+ today) and automatically picks up future security releases — the pattern already used by the other org repos.
  • pr-build.yml exercises the updated Node version on this PR.

🤖 Generated with Claude Code

The 2026-10-21 Node.js security release fixed CVE-2026-111497 (Brotli decoder out-of-bounds write, potential RCE) plus nine other CVEs; the patched 24.x line is v24.22.1. The workflows were pinned to 24.19.0, which predates the fix. Use a floating 24.x spec so future security patches are picked up automatically.

Co-Authored-By: Claude Code <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 2, 2026 17:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Both workflows can still select a pre-fix Node.js 24 release from the runner cache because setup-node does not enable check-latest, leaving the security update dependent on runner-image updates.

1 open issue
What changed in this PR

This PR updates the site’s CI and deployment workflows to use the floating Node.js 24.x range, intended to pick up security fixes without manually updating a pinned version.

Changes:

  • Replaces Node.js 24.19.0 with 24.x in both workflow matrices.
  • Leaves existing build, test, and deployment steps unchanged.
File Description
.github/​workflows/​pr-build.yml Uses Node.js 24.x for pull-request tests and builds.
.github/​workflows/​deploy.yml Uses Node.js 24.x for deployment builds.

Review effort: Balanced

Comment thread .github/workflows/deploy.yml Resolved
@bingenito
bingenito enabled auto-merge November 2, 2026 17:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants