Persist selected package provider in Package Management - #16984
Open
Ibochkarev wants to merge 3 commits into
Open
Persist selected package provider in Package Management#16984Ibochkarev wants to merge 3 commits into
Ibochkarev wants to merge 3 commits into
Conversation
Store the active provider in the default_provider system setting so the toolbar label, browser breadcrumbs, and Download Extras flow keep the user's choice after reload instead of resetting to modx.com.
Drop the Russian workspace/setting lexicon edits so translators pick up the new keys from the English files.
Ibochkarev
force-pushed
the
fix/16446-persist-package-provider
branch
from
August 11, 2026 08:36
4b05bce to
8dd8f3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Package Management forgot which provider you picked. After a refresh it jumped back to modx.com, and the Packages toolbar never showed the active provider name. That matches the report in #16446.
This change stores the choice in the existing
default_providersystem setting (already read by the workspaces controller). Choosing a provider in “Save and go to Package Browser” now writes that setting through a smallWorkspace/Providers/SetDefaultprocessor, then updates the in-memory provider and toolbar label. The Packages toolbar showsProvider: {name}, and the package browser breadcrumbs / home copy include the same name.Also removed the mid-session reset in
onDownloadMoreExtraand thechangeGProvider/changePProviderflags in the browser tree. Those flags only delayed store updates and made provider switches harder to follow.How to test
Provider: …with the current default.default_providerand confirm the value matches.Related issue(s)/PR(s)
Resolves #16446
Compatibility notes
Universal for the manager Package Management UI. Fresh installs get
default_providerfrom transport. Existing installs create the setting on first successful save viaSetDefault(upsert). No CLI or REST API change.Breaking change assessment
No public API signature changes. Default runtime behavior for sites that never change provider stays modx.com (id
1). Sites that select another provider now keep that choice across reloads, which is the intended fix for #16446.Test coverage
No automated tests added. Coverage is manual UI verification against a local manager install (provider switch, persist across reload, Download Extras without reset). Processor path is a thin setting upsert with permission
workspaces.Contributors
Thanks to everyone who documented the original behavior in #16446.
AI tool use
Cursor (agent) helped implement the manager JS/PHP changes, run local verification against Valet, and draft this PR text. Human review and merge decision remain required.