Fix BMI088 driver getting stuck + GenericTimeout::wait() behavior#1353
Merged
Conversation
Member
Author
|
I'll also add a unit test tomorrow |
Also fixes the BMI088 driver getting stuck during initialization. The current implementation blocks until execute() returns true. In case wait() is used twice, execute() has been called on the expired timer or the timer is stopped the program blocks forever. This behaviour is unexpected and caused a bug in a refactoring of the BMI088 driver. It gets stuck indefinitely during initialize() which will be fixed by this change.
chris-durand
force-pushed
the
fix/timer_wait_bm088
branch
from
366182f to
2d8c1b4
Compare
Member
Author
|
@salkinium I've added the test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the BMI088 driver getting stuck during initialization. This was caused by a refactoring using
GenericTimeout::wait().The timer implementation is changed to wait as long as the timer is armed instead of waiting for
execute()to return true. This prevents several edge cases where the wait function blocks indefinitely.Fixes #1352