Repository navigation
fix(website): make brand logo downloads visible in any viewer - #1230
Merged
Merged
Conversation
The brand PNGs were single-color logos on a transparent background, so paper variants looked blank in light image viewers and ink variants nearly vanished in dark ones (including Chrome's image view). The flat mark and wordmark were also cropped flush to the image edge. Add a solid-background PNG per logo and color (ink on paper, paper on ink) alongside the transparent one, and pad every source SVG's viewBox by about one stem-width so all exports share the same clear space. Regenerate the downloads and ZIP, and assert each PNG's corner pixel in the brand smoke test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds solid-background PNG downloads while keeping transparent versions. Widens the SVG bounds to give each logo clear space.
Reviews (1) · Last reviewed commit: "fix(website): make brand logo downloads ..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The logo downloads on hunk.dev/brand looked broken once opened, especially the PNGs. Every file served and decoded correctly. The trouble was how they looked on their own:
Changes
<logo>-<color>-solid.png, filled with its paired background (ink on paper#f4f1ea, paper on ink#16140f). The transparent PNGs stay. Each download row on the page gains a "Solid PNG" link, and the links wrap on narrow cards.brandFormatsinwebsite/src/data/brand.tsis now a list of format objects (id,label,name,extension), and the generator renders every non-SVG format from it.website/public/brand/downloads/andhunk-brand.zip(now 33 files) withbun run generate:brand. Updated the page copy, the README in the ZIP, anddocs/brand.md.Reviewer notes
scripts/launch-video/compose.mjsinlineslogo-lockup-paper.svgat a fixed width. Because the padding is now inside the SVG, the lockup will look about 4% smaller in future launch videos.og.pngand the docs favicon still use the old logo (already noted indocs/brand.md).Verification
cd website && bun run build: passes.cd website && bunx playwright test tests/brand-smoke.spec.ts: 6/6 pass (desktop + mobile Chromium), including the axe check in both themes. The download test now decodes each PNG and asserts its top-left pixel: clear for transparent PNGs, the paired background for solid PNGs. That covers both the padding and the background, and it would have failed on the old flat-mark PNG.oxfmt --checkandoxlint --deny-warningson the changed files: clean.🤖 Generated with Claude Code