Repository navigation
fix(ci): keep baseline CPU probes on compatible cloud runners - #1227
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryPins the two Linux x64 build jobs that run the Nehalem check to Ubuntu 24.04.
Reviews (1) · Last reviewed commit: "fix(ci): keep baseline CPU probes on com..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The merged 0.24.1 release preparation hit SIGILL in main's
qemu-x86_64 -cpu Nehalem dist/hunk --versioncheck. It fails consistently on the newubuntu-latestimage (Ubuntu 26.04 on Azure), despite selecting Bun's baseline runtime. The release workflow uses the same runner and probe, so publication is paused before creating any tag.The runner's system libraries require x86-64-v3. Ubuntu 26.04 cloud images now enable the amd64v3 variant by default (Ubuntu release notes); CI logs show the amd64v3 package repository. QEMU user-mode emulation loads the host's dynamic linker and libraries into the emulated process. Nehalem cannot execute their AVX-family instructions, regardless of whether Hunk itself is baseline-compatible.
Reproduction and controls
Using the same local
dist/hunkthroughout:APT::Architecture-Variants "amd64v3";, update/upgrade the same Ubuntu 26.04 container, then installqemu-user: both/bin/trueand Hunk fail with SIGILL / exit 132 under Nehalem./bin/trueand Hunk both pass under Nehalem.vpxor %ymm0, %ymm0, %ymm0instruction still fails with exit 132 on that Ubuntu 24.04 probe. The old-CPU check remains effective; its CPU model is not being relaxed.Fix
build-binjob and the release matrix's Linux x64 build toubuntu-24.04.Validation
bun test ./scripts/quality/baseline-workflows.test.ts ./scripts/build/build-bin.test.ts— 16 pass.bun run typecheck— pass.bun run test— both full test shards pass.bunx oxfmt --check ...and focusedoxlint— pass.tmp/install-vm/runs/baseline-fix-lBRUXGgZ/result.json, source identity4a1fafd2c66ed14faec8338836001891c79a9f6eba6a579395ce56c13e4b3413.The main-only compiled-binary job must run after merge to verify the GitHub runner itself. No tag was created and nothing has been published. Release 0.24.1 remains held pending green validation and maintainer confirmation.
This PR description was generated by Pi using GPT-6.1-sol