Repository navigation
fix(skills): fall back to hunk skill path in pointer skills - #1220
Merged
benvinegar merged 1 commit intoOct 25, 2026
Conversation
Signed-off-by: ShryukGrandhi <85529990+ShryukGrandhi@users.noreply.github.com>
Contributor
|
PR author is not in the allowed authors list. |
|
@ShryukGrandhi is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
benvinegar
enabled auto-merge (squash)
October 25, 2026 13:44
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npx skills add modem-dev/hunkinstalls the pointer skills from.agents/skills/onmain, whatever Hunk version the user has installed. The pointer only tells the agent to runhunk skill show <name>, which was added in 0.24. On 0.23 and earlier that command fails withhunk: Only `hunk skill path` is supported., so the agent gets no instructions unless it works out the fallback by itself.Fixes #1190
Changes
scripts/generate/skillPointer.ts: the generated pointer still runshunk skill show <name>first. If that fails, it now tells the agent to runhunk skill path <name>(available with a skill name since 0.19), then read and follow that file..agents/skills/hunk-review/SKILL.mdand.agents/skills/hunk-extensions/SKILL.mdwithbun run generate:skill.scripts/generate/skillPointer.test.ts: checks that the pointer includes thehunk skill pathfallback. The existing test that compares the checked-in pointers to the generator output also covers the regenerated files.Testing
bun test scripts/generate/skillPointer.test.ts: the new assertion fails before the fix and passes after it.bun test scripts/generate test/cli/entrypoint.test.ts: 168 pass.bun run typecheck,bun run format:check,oxlint scripts/generate --deny-warnings: clean.bun run packages/hunk/src/main.tsx -- skill path hunk-reviewprints the bundled skill path.Tested on macOS (arm64) only.