Skip to content

fix(skills): fall back to hunk skill path in pointer skills - #1220

Merged
benvinegar merged 1 commit into
modem-dev:mainfrom
ShryukGrandhi:fix/issue-1190-hunk-review-pointer-skill-asks-agents-to
Oct 25, 2026
Merged

benvinegar merged 1 commit into
modem-dev:mainfrom
ShryukGrandhi:fix/issue-1190-hunk-review-pointer-skill-asks-agents-to

Conversation

@ShryukGrandhi

Copy link
Copy Markdown
Contributor

Summary

npx skills add modem-dev/hunk installs the pointer skills from .agents/skills/ on main, whatever Hunk version the user has installed. The pointer only tells the agent to run hunk skill show <name>, which was added in 0.24. On 0.23 and earlier that command fails with hunk: Only `hunk skill path` is supported., so the agent gets no instructions unless it works out the fallback by itself.

Fixes #1190

Changes

  • scripts/generate/skillPointer.ts: the generated pointer still runs hunk skill show <name> first. If that fails, it now tells the agent to run hunk skill path <name> (available with a skill name since 0.19), then read and follow that file.
  • Regenerated .agents/skills/hunk-review/SKILL.md and .agents/skills/hunk-extensions/SKILL.md with bun run generate:skill.
  • scripts/generate/skillPointer.test.ts: checks that the pointer includes the hunk skill path fallback. The existing test that compares the checked-in pointers to the generator output also covers the regenerated files.
  • Added a sentence about the fallback to the review-skill docs page, plus a patch Changeset.

Testing

  • bun test scripts/generate/skillPointer.test.ts: the new assertion fails before the fix and passes after it.
  • bun test scripts/generate test/cli/entrypoint.test.ts: 168 pass.
  • bun run typecheck, bun run format:check, oxlint scripts/generate --deny-warnings: clean.
  • bun run packages/hunk/src/main.tsx -- skill path hunk-review prints the bundled skill path.

Tested on macOS (arm64) only.

Signed-off-by: ShryukGrandhi <85529990+ShryukGrandhi@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown

@ShryukGrandhi is attempting to deploy a commit to the Modem Team on Vercel.

A member of the Team first needs to authorize it.

@benvinegar
benvinegar enabled auto-merge (squash) October 25, 2026 13:44
@benvinegar

Copy link
Copy Markdown
Member

Thanks!

@benvinegar
benvinegar merged commit 3910f11 into modem-dev:main Oct 25, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hunk-review pointer skill asks agents to run the wrong command

2 participants